RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v9]

Kevin Rushforth kcr at openjdk.org
Tue Jul 9 11:40:37 UTC 2024


On Mon, 8 Jul 2024 22:53:24 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> We have many tests that will occasionally fail with a heavily loaded system.
>> 
>> The question is whether we can come up with a max delta that we can reliably use that is less than the difference between the default value and the test value. Otherwise, we can't distinguish them.
>> 
>> On two different test systems, both of which fail pretty consistently with  50 msec, I see a 100% pass rate over several tries with 150 msec. More testing is needed.
>
> Another possibility is the code that measures the time it takes to show the tooltip.
> 
> The current code uses Util.waitForLatch(), L244 which was written for a different use case and actually introduces a small measurement error as it includes the time needed for the context switch.  Perhaps a better solution would be to note the timestamp in L271 where the tooltip listener gets called (similar to the way the start moment is captured in L241)

Good catch. Capturing the current time in the listener will be more accurate than doing it after the latch wait.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1670360729


More information about the openjfx-dev mailing list