RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v9]

Marius Hanl mhanl at openjdk.org
Wed Jul 10 09:18:22 UTC 2024


On Tue, 9 Jul 2024 11:38:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Another possibility is the code that measures the time it takes to show the tooltip.
>> 
>> The current code uses Util.waitForLatch(), L244 which was written for a different use case and actually introduces a small measurement error as it includes the time needed for the context switch.  Perhaps a better solution would be to note the timestamp in L271 where the tooltip listener gets called (similar to the way the start moment is captured in L241)
>
> Good catch. Capturing the current time in the listener will be more accurate than doing it after the latch wait.

Good catch indeed. Will test and report back accordingly.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1671923946


More information about the openjfx-dev mailing list