RFR: 8336389: Infinite loop occurs while resolving lookups [v2]

[Andy Goryachev]

On Mon, 15 Jul 2024 13:30:13 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Fixes an infinite loop that can occur while resolving lookups.
>> 
>> There were 2 bugs:
>> - A `contains` check was done on some value X, but then a value Y was added to the set used to track duplicates
>> - The `Set` to track duplicates was cleared in some recursive calls, meaning that the caller (which may be processing multiple values in a loop) would end up with an empty set, losing track of what was visited so far
>> 
>> Also removed a redundant `null` check (an NPE would have occurred before it could reach that code).
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting and spelling

This might be unrelated, but every time the CssParser gets recompiled in Eclipse I get a bunch of errors (and the errors get cleared after a clean/rebuild):


Description	Resource	Type	Path	Location
Cannot infer type arguments for ParsedValueImpl<>	CssParser.java	Java Problem	/graphics/src/main/java/javafx/css	line 2927
Cannot infer type arguments for ParsedValueImpl<>	CssParser.java	Java Problem	/graphics/src/main/java/javafx/css	line 3117
Cannot infer type arguments for ParsedValueImpl<>	CssParser.java	Java Problem	/graphics/src/main/java/javafx/css	line 3170
Cannot infer type arguments for ParsedValueImpl<>	CssParser.java	Java Problem	/graphics/src/main/java/javafx/css	line 3185
Cannot infer type arguments for ParsedValueImpl<>	CssParser.java	Java Problem	/graphics/src/main/java/javafx/css	line 3510
Cannot infer type arguments for ParsedValueImpl<>	CssParser.java	Java Problem	/graphics/src/main/java/javafx/css	line 3554


even though it's a perfectly correct code.  Any ideas?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1505#issuecomment-2231406801