RFR: 8336389: Infinite loop occurs while resolving lookups [v2]
John Hendrikx
jhendrikx at openjdk.org
Tue Jul 16 19:48:56 UTC 2024
On Mon, 15 Jul 2024 19:06:30 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
> A new `HashSet` is created for every base call to `resolveLookups`, but it is only used for state tracking. We could re-use the instance for subsequent calls.
It's a bit of waste, and as the code is single threaded, it could be shared. However, CSS calculations are cached already, and so this probably won't do anything. Keeping this PR focused on the fix seems better.
If we're gonna optimize, I think it would be better to do some measurements first to see if there is at least 1 ms or more to win anywhere.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1505#issuecomment-2231708680
More information about the openjfx-dev
mailing list