RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet [v2]
Andy Goryachev
angorya at openjdk.org
Fri Jul 19 23:29:39 UTC 2024
On Fri, 19 Jul 2024 22:54:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add test case
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 710:
>
>> 708: INLINE_VARIABLE_OVERRIDES_USER_AGENT_VARIABLE(RED_INDIRECT_STYLESHEET, null, null, "-fx-base: #808080"),
>> 709: INLINE_VARIABLE_OVERRIDES_AUTHOR_VARIABLE(RED_INDIRECT_STYLESHEET, null, FX_BASE_GREEN_STYLESHEET, "-fx-base: #808080");
>> 710:
>
> also, would it make sense to add tests for null/empty userAgentStylesheet, for completeness sake?
Another question:
do we want to go through all the cases of Scene/SubScene/Parent/Region user agent style sheet, for completeness sake, or would that be a different test file?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1685087427
More information about the openjfx-dev
mailing list