RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet [v2]
John Hendrikx
jhendrikx at openjdk.org
Mon Jul 22 10:04:42 UTC 2024
On Fri, 19 Jul 2024 22:56:22 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> Another question: do we want to go through all the cases of Scene/SubScene/Parent/Region user agent style sheet, for completeness sake, or would that be a different test file?
In my opinion, this does seem a bit of out of scope for this change. It would not add any new coverage to the code that was changed. Also the origin of the user agent stylesheet is not a factor in the resolution of lookups. The user agent stylesheets, their replacement (via Scene/Subscene) or addition (via Region) should (already?) be tested elsewhere.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686300569
More information about the openjfx-dev
mailing list