RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet [v2]

John Hendrikx jhendrikx at openjdk.org
Mon Jul 22 09:59:40 UTC 2024


On Fri, 19 Jul 2024 23:23:45 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test case
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 73:
> 
>> 71:     }
>> 72: 
>> 73:     @BeforeEach
> 
> since we are now creating Stage every time, shouldn't we `hide()` it each time?

This was already done each time, it has not changed, only the annotation.  The semantics of `@Before` in JUnit 4 and `@BeforeEach` in JUnit 5 are the same.  However, see #1515 as I'll remove these changes from this PR.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686294085


More information about the openjfx-dev mailing list