RFR: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet [v2]

[John Hendrikx]

On Mon, 22 Jul 2024 09:56:41 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java line 73:
>> 
>>> 71:     }
>>> 72: 
>>> 73:     @BeforeEach
>> 
>> since we are now creating Stage every time, shouldn't we `hide()` it each time?
>
> This was already done each time, it has not changed, only the annotation.  The semantics of `@Before` in JUnit 4 and `@BeforeEach` in JUnit 5 are the same.  However, see #1515 as I'll remove these changes from this PR.

I'm not entirely sure on the semantics of `Stage` when it is run with the stub toolkit; I suspect they won't stick around when no longer referenced, or this test would have been an issue when it was created years ago already.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686304866