Integrated: 8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet

John Hendrikx jhendrikx at openjdk.org
Wed Jul 24 01:16:41 UTC 2024


On Fri, 12 Jul 2024 10:25:57 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> This change removes the origin determination from `resolveLookups`.  Instead, the origin from the style is used.
> 
> Although a comment in the code alluded that this may cause problem with `INLINE` styles, this is not the case. Whenever a `Node` is associated with a `CssStyleHelper`, a suitable shared cache is determined for its use.  This already takes into account the presence of an inline style, and only nodes with the same inline style can share such a cache.  See `Cache#getStyleMap` and specifically this fragment where an additional selector is added for the inline style:
> 
>             if (hasInlineStyle) {
>                 Selector selector = cacheContainer.getInlineStyleSelector(inlineStyle);
>                 if (selector != null) selectors.add(selector);
>             }

This pull request has now been integrated.

Changeset: ffbd12dc
Author:    John Hendrikx <jhendrikx at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/ffbd12dc01132f186908eb83144ff17c4b4bdeaf
Stats:     125 lines in 2 files changed: 102 ins; 17 del; 6 mod

8336097: UserAgent Styles using lookups are promoted to Author level if look-up is defined in Author stylesheet

Reviewed-by: angorya, mstrauss, kcr

-------------

PR: https://git.openjdk.org/jfx/pull/1503


More information about the openjfx-dev mailing list