RFR: 8336331: Doc: Clarification in AccessibleAttribute, AccessibleRole [v2]

Andy Goryachev angorya at openjdk.org
Wed Jul 24 17:08:38 UTC 2024


On Wed, 24 Jul 2024 08:54:59 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Hmm, actually, `IndexRange.getStart()` L76 and `.getEnd()` L84 refer to start/end _position_.
>
> I was just sharing an observation, wasn't expecting any change.
> In this file, documentation already refer them as offset at a few places, like BOUNDS_FOR_RANGE, LINE_START, LINE_END.
> So, offset seems more suitable in this file.

ok, will revert.

>> Thanks for catching this!
>> 
>> Only TextArea has a meaningful implementation, all other descendants of TextInputControl have a no-op (see `scrollCharacterToVisible()`, TextInputControlSkin:736)
>> 
>> We need to remove TextField mention from `AccessibleAction.SHOW_TEXT_RANGE`.
>
> TextField can be scrolled horizontally, so seems like even TextField should respond to SHOW_TEXT_RANGE.
> So, instead of removing TextField mention from AccessibleAction.SHOW_TEXT_RANGE, a bug can/should be filed for missing implementation.
> What do you think ?

The intent of this PR is to bring the doc in sync with reality.

I can create an enhancement request for adding support for `SHOW_TEXT_RANGE` in all TextInputControl descendants, but I am not sure whether the current implementation is a result of some kind of business decision or requirement.

@azuev-java what do you think?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1690159251
PR Review Comment: https://git.openjdk.org/jfx/pull/1512#discussion_r1690156555


More information about the openjfx-dev mailing list