RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v6]

Marius Hanl mhanl at openjdk.org
Tue Jun 4 12:42:13 UTC 2024


On Tue, 28 May 2024 16:51:11 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a test for changing the stylesheet and always process CSS for that matter
>
> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 493:
> 
>> 491:                 scene.setUserAgentStylesheet(ownerScene.getUserAgentStylesheet());
>> 492:             }
>> 493:             scene.getStylesheets().setAll(ownerScene.getStylesheets());
> 
> so if the application decides to set a particular style sheet on the tooltip scene, it will be ignored?  Should it be addAll()?  And if yes, should it check against duplicate entries?

Yes, but I did not change this behaviour, as this method is always called right before showing.
While this a bit weird, this is out of scope for at least this PR.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1625931951


More information about the openjfx-dev mailing list