RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

Kevin Rushforth kcr at openjdk.org
Thu Jun 13 11:49:22 UTC 2024


On Thu, 13 Jun 2024 07:21:47 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> The new test passed with both the old and the new version (I reverted the code, aside from leaving `setMenuBindings` `protected`). Is the test testing the right thing?
> 
> (If relevant, this was done on a Windows platform)

That's not surprising since only macOS provides the (optional) system menu capability, and the leak is in the glass system menu implementation. The tests will pass vacuously on other platforms, since the system menu code with the bug will never be reached.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1283#issuecomment-2165425472


More information about the openjfx-dev mailing list