RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

[Johan Vos]

On Thu, 13 Jun 2024 10:25:15 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add more type info
>
> modules/javafx.graphics/src/shims/java/com/sun/javafx/tk/quantum/GlassSystemMenuShim.java line 37:
> 
>> 35: 
>> 36:     private GlassSystemMenu gsm;
>> 37:     final ArrayList<WeakReference<Menu>> uncollectedMenus = new ArrayList<>();
> 
> this can be private?

done

> modules/javafx.graphics/src/shims/java/com/sun/javafx/tk/quantum/GlassSystemMenuShim.java line 54:
> 
>> 52:     protected void setMenuBindings(final Menu glassMenu, final MenuBase mb) {
>> 53:         super.setMenuBindings(glassMenu, mb);
>> 54:         uncollectedMenus.add(new WeakReference(glassMenu));
> 
> Add `<>` to avoid raw use of `WeakReference`

done

> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java line 289:
> 
>> 287:     public void testJDK8309935() {
>> 288:         MenuBar menuBar = new MenuBar();
>> 289:         AtomicReference<Throwable> throwableRef = new AtomicReference();
> 
> Add missing `<>` to avoid raw use of `AtomicReference`

done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1638809325
PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1638809211
PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1638809871