RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v4]

[Markus Mack]

On Fri, 21 Jun 2024 22:07:22 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Markus Mack has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   testAddingDataAtIndex & fix
>
> modules/javafx.controls/src/main/java/javafx/scene/chart/BarChart.java line 227:
> 
>> 225:                 var uniqueCategories = new HashSet<String>();
>> 226:                 for (var entry : seriesCategoryMap.entrySet()) {
>> 227:                     Series s = entry.getKey();
> 
> would it make sense to add a comment explaining the reasoning for this more complex code?

I've extended the code comment.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1476#discussion_r1649628640