RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v4]

Andy Goryachev angorya at openjdk.org
Mon Jun 24 14:58:22 UTC 2024


On Sat, 22 Jun 2024 10:52:42 GMT, Markus Mack <mmack at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/chart/BarChart.java line 227:
>> 
>>> 225:                 var uniqueCategories = new HashSet<String>();
>>> 226:                 for (var entry : seriesCategoryMap.entrySet()) {
>>> 227:                     Series s = entry.getKey();
>> 
>> would it make sense to add a comment explaining the reasoning for this more complex code?
>
> I've extended the code comment.

thank you

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1476#discussion_r1651183756


More information about the openjfx-dev mailing list