RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v2]

[Markus Mack]

On Tue, 25 Jun 2024 20:06:29 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Markus Mack has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - cleanup imports
>>  - add clarifying comment to test
>
> modules/javafx.controls/src/main/java/javafx/scene/chart/Axis.java line 753:
> 
>> 751: 
>> 752:             // call tick marks updated to inform subclasses that we have updated tick marks
>> 753:             tickMarksUpdated();
> 
> is this the only place where this call needs to be added?
> 
> for example, in BarChart the x axis is not updated after "Add series with duplicate category" - is this a separate issue?
> 
> 
> ![Screenshot 2024-06-25 at 11 58 52](https://github.com/openjdk/jfx/assets/107069028/672c0804-fd00-4bc1-9c01-bd89f41056dc)
> 
> ^^ is this a separate issue?

yes, the BarChart issue (which I actually want to get fixed) will need additional fixes in other classes. I could add those to this PR, but probably it's best to handle them in another ticket+PR to keep this PR affecting all `Chart`s minimal?

> modules/javafx.controls/src/test/java/test/javafx/scene/chart/XYNumberLineChartsTest.java line 156:
> 
>> 154:         NumberAxis yAxis = (NumberAxis)chart.getYAxis();
>> 155: 
>> 156:         List<Double> majorTickYValues = yAxis.getChildrenUnmodifiable().stream()
> 
> does this code captures the ticks before the first frame of animation or after the first frame?
> 
> should we also check after the animation ran its course?  (I assume animation does work with the StubToolkit)

this is after the animation is finished, I added a clarifying comment to the test code.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1489#discussion_r1653607166
PR Review Comment: https://git.openjdk.org/jfx/pull/1489#discussion_r1653606713