RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v2]

Andy Goryachev angorya at openjdk.org
Tue Jun 25 21:46:26 UTC 2024


On Tue, 25 Jun 2024 21:42:23 GMT, Markus Mack <mmack at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/chart/Axis.java line 753:
>> 
>>> 751: 
>>> 752:             // call tick marks updated to inform subclasses that we have updated tick marks
>>> 753:             tickMarksUpdated();
>> 
>> is this the only place where this call needs to be added?
>> 
>> for example, in BarChart the x axis is not updated after "Add series with duplicate category" - is this a separate issue?
>> 
>> 
>> ![Screenshot 2024-06-25 at 11 58 52](https://github.com/openjdk/jfx/assets/107069028/672c0804-fd00-4bc1-9c01-bd89f41056dc)
>> 
>> ^^ is this a separate issue?
>
> yes, the BarChart issue (which I actually want to get fixed) will need additional fixes in other classes. I could add those to this PR, but probably it's best to handle them in another ticket+PR to keep this PR affecting all `Chart`s minimal?

a separate PR would be best.  I am getting lost - do we have a ticket for that issue already or do we need to create one?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1489#discussion_r1653608450


More information about the openjfx-dev mailing list