RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v2]

Andy Goryachev angorya at openjdk.org
Tue Jun 25 22:09:14 UTC 2024


On Tue, 25 Jun 2024 21:41:54 GMT, Markus Mack <mmack at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/XYNumberLineChartsTest.java line 156:
>> 
>>> 154:         NumberAxis yAxis = (NumberAxis)chart.getYAxis();
>>> 155: 
>>> 156:         List<Double> majorTickYValues = yAxis.getChildrenUnmodifiable().stream()
>> 
>> does this code captures the ticks before the first frame of animation or after the first frame?
>> 
>> should we also check after the animation ran its course?  (I assume animation does work with the StubToolkit)
>
> this is after the animation is finished, I added a clarifying comment to the test code.

thank you

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1489#discussion_r1653631212


More information about the openjfx-dev mailing list