RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

John Hendrikx jhendrikx at openjdk.org
Mon Mar 4 17:22:58 UTC 2024


On Mon, 4 Mar 2024 11:03:26 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> @andy-goryachev-oracle  The coverage comes from EclEmma, an Eclipse plugin. Once installed, there is another way to run tests called `Coverage as...` just above `Run as...`.  It's very useful to use it on a JUnit test to see if there are major branches you missed in testing that may require additional cases.
>
> Thank you @hjohn for providing the test. I have added this.
> Since we do not use scene in this test, I think it is difficult to test HitInfo in RTL mode. However these tests will be very useful in testing the HitInfo.

I think it's possible even in the JUnit test. You can call `setDirection` on `layout` to set mirroring.

However, since we removed `isMirrored` check in `getHitInfo`, the code is no longer dependent on whether the text is mirrored or not, so extra tests won't catch anything new.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1511512588


More information about the openjfx-dev mailing list