RFR: 8307980: Rotate Transformation never invalidates inverseCache [v3]

Kevin Rushforth kcr at openjdk.org
Thu Mar 28 12:22:35 UTC 2024


On Thu, 28 Mar 2024 11:23:02 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Fixed as described in the issue + added tests to check for this scenario with all Transform sub classes. Since the test scenario slightly exceeding the regular parametrized testing of `TransformOperationsTest` I decided to implement the tests in a separate class.
>> 
>> I didn't manage to reproduce the issue with other Transform sub classes, so it seems to only affect `Rotate`. Also checked by looking at the code, only `Rotate` was affected by this bug. As such, without 08ba284 only `testTransformInverseCache_Rotate` fails, while others succeed. With the fix, all tests pass.
>> 
>> Ran the whole test suite afterwards and didn't notice any changes to test results after introducing the fix.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing EOF newline

Marked as reviewed by kcr (Lead).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1392#pullrequestreview-1966034023


More information about the openjfx-dev mailing list