Integrated: 8307980: Rotate Transformation never invalidates inverseCache

Lukasz Kostyra lkostyra at openjdk.org
Thu Mar 28 12:57:39 UTC 2024


On Wed, 6 Mar 2024 15:51:16 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

> Fixed as described in the issue + added tests to check for this scenario with all Transform sub classes. Since the test scenario slightly exceeding the regular parametrized testing of `TransformOperationsTest` I decided to implement the tests in a separate class.
> 
> I didn't manage to reproduce the issue with other Transform sub classes, so it seems to only affect `Rotate`. Also checked by looking at the code, only `Rotate` was affected by this bug. As such, without 08ba284 only `testTransformInverseCache_Rotate` fails, while others succeed. With the fix, all tests pass.
> 
> Ran the whole test suite afterwards and didn't notice any changes to test results after introducing the fix.

This pull request has now been integrated.

Changeset: b3f5a789
Author:    Lukasz Kostyra <lkostyra at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/b3f5a7896830ae3fa9abf2c684f6b9279f4b926b
Stats:     119 lines in 2 files changed: 119 ins; 0 del; 0 mod

8307980: Rotate Transformation never invalidates inverseCache

Reviewed-by: kcr

-------------

PR: https://git.openjdk.org/jfx/pull/1392


More information about the openjfx-dev mailing list