RFR: 8271865: SortedList::getViewIndex behaves not correctly for some index values [v2]
drmarmac
duke at openjdk.org
Thu May 2 13:12:09 UTC 2024
On Thu, 2 May 2024 12:18:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> drmarmac has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JavaDoc updates
>
> modules/javafx.base/src/main/java/javafx/collections/transformation/TransformationList.java line 121:
>
>> 119: * @param index the index in this list
>> 120: * @return the index of the element's origin in the source list
>> 121: * @throws IndexOutOfBoundsException if the index is out of range (<code>index < 0 || index >= size()</code>)
>
> In javadoc comments, we prefer using `{@code ... }` rather than the raw HTML tags. This also allows using `<` rather than `<`.
>
> Suggested change:
>
>
> ... ({@code index < 0 || index >= size()})
ok, looks better!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1432#discussion_r1587609916
More information about the openjfx-dev
mailing list