RFR: 8332313: Update code review guidelines
Kevin Rushforth
kcr at openjdk.org
Wed May 15 22:24:08 UTC 2024
On Wed, 15 May 2024 20:33:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> He means people reading reviews are usually on github and your github ID is kevinrusforth,
>> so they might be confused by "kcr" which is your openjdk id.
>>
>> Since the context is identifying OpenJDK Project leads, I think the OpenJDK ID is the right and only one to include here. At most you could clarify like (OpenJDK ID - kcr)
>
> exactly my point. when the majority of time is spent in the context of github (PR review etc) it might be confusing when one types `@jvos` and it's not found, or when within a PR there are references to both `jvos` and `johanvos`
>
> (see the very first comment in https://github.com/openjdk/jfx/pull/1388 )
Ah, I misunderstood Andy's comment. Yes, I'll update this.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602297383
More information about the openjfx-dev
mailing list