RFR: 8301121: RichTextArea Control (Incubator) [v28]

[Kevin Rushforth]

On Tue, 29 Oct 2024 19:38:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java line 34:
>> 
>>> 32:  * For that, use {@link Marker}.
>>> 33:  */
>>> 34: public final class TextPos implements Comparable<TextPos> {
>> 
>> Remind me why this isn't a record? It seems like it could be, unless I'm missing something.
>
> it could be.  
> 
> does it absolutely have to be?  the class is final, and we have greater flexibility in naming the accessors than with a record, not that we use it here.

A record seems more natural here, so would be the default choice, but if there is a good reason not to, I don't see it as a requirement.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1826181164