RFR: 8309381: Support JavaFX incubator modules

[Andy Goryachev]

On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> This PR add the necessary support for [JavaFX Incubator Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). It includes the following:
> 
> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to document where to add your incubator module. Also added `jlink` flags to not resolve incubator modules by default and warn when resolving (same as is done for JDK incubator modules).
> 2. A utility class to produce warnings when first using an incubator module.
> 3. Changes to `javafx.base/module-info.java` to document where to add the needed qualified exports to your module to access the utility class in 2.
> 
> See PR #1617 for a sample module that is built on top of this PR's source branch.
> 
> This is almost ready to review. I will take it out of Draft in the next day or so.

looks consistent with the original changes, but easier to understand.

had a few minor suggestions, will re-approve if you decide to fix it (WRAIYDTFI).

build.gradle line 2877:

> 2875: // Add a project declaration for each incubator module here, leaving the
> 2876: // incubator placeholder lines as an example.
> 2877: // BEGIN: incubator placeholder

Q: maybe we should mention the JBS every time we say the word "incubator"?

It might be useful to anyone who is looking at the code and has no access to git history (or when git history is obscured by a move).  I mean, JBS is our knowledge base, and it usually helps.

build.gradle line 4053:

> 4051:         //'incubator.mymod',
> 4052:         // END: incubator placeholder
> 4053: 

(same comment about empty lines)

settings.gradle line 42:

> 40:         "web",
> 41:         "media",
> 42:         "systemTests"

thank you for placing each entry on a separate line!

I would prefer to remove the blank lines around the comment so as not to break the visual grouping (the comments are typically syntax colored anyway unless the user is on TRS80)

settings.gradle line 53:

> 51: //project(":incubator.mymod").projectDir = file("modules/jfx.incubator.mymod")
> 52: // END: incubator placeholder
> 53: 

same suggestion about empty lines

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1616#pullrequestreview-2416811452
PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1830084515
PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1830080016
PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1830078671
PR Review Comment: https://git.openjdk.org/jfx/pull/1616#discussion_r1830079024