RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v2]

[Kevin Rushforth]

On Wed, 6 Nov 2024 05:13:48 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> This PR removes AccessController.doPrivileged() calls in javafx.graphics/com.sun.glass. It is part of umbrella task [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441).
>> 
>> Also wherever classes are implementing PrivilegedAction they are replaced with java.util.Supplier and get().
>> 
>> I have removed reference to all AccessControl** class except in `Accessible.java` assuming that AccessControlContext from this class might be needed at some other place and its better if we remove it under [JDK-8342993](https://bugs.openjdk.org/browse/JDK-8342993)
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update based on review comments

modules/javafx.graphics/src/main/java/com/sun/glass/ui/Accessible.java line 186:

> 184:             executeAction.action = action;
> 185:             executeAction.parameters = parameters;
> 186:             return executeAction;

I just noticed that this has the same problem that `getAttribute` had, which I reported and you fixed. The return value isn't used (so we didn't get a fail fast), but I'm pretty sure that this will cause a problem in that `executeAction` will never be executed.

For consistency, you might consider changing it in the same way as you did for `getAttribute`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1624#discussion_r1831260172