RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v2]
Jayathirth D V
jdv at openjdk.org
Thu Nov 7 07:20:48 UTC 2024
On Wed, 6 Nov 2024 15:37:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update based on review comments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Accessible.java line 186:
>
>> 184: executeAction.action = action;
>> 185: executeAction.parameters = parameters;
>> 186: return executeAction;
>
> I just noticed that this has the same problem that `getAttribute` had, which I reported and you fixed. The return value isn't used (so we didn't get a fail fast), but I'm pretty sure that this will cause a problem in that `executeAction` will never be executed.
>
> For consistency, you might consider changing it in the same way as you did for `getAttribute`.
I have updated executeAction also. Looks like this call reaches from MacAccessible under certain conditions on macOS.
To instrument and verify, i ran different a11y tests in Hello toy(with VoiceOver) and found out that clicking on any Item in `HelloSimpleTableView` calls executeAction. So after the update also we receive this call.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1624#discussion_r1832169683
More information about the openjfx-dev
mailing list