RFR: 8313424: JavaFX controls in the title bar [v21]

[Michael Strauß]

On Tue, 5 Nov 2024 18:54:11 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   stylistic changes
>
> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 83:
> 
>> 81:      * <p>
>> 82:      * An extended window has the default window buttons (minimize, maximize, close), but no system-provided
>> 83:      * draggable header bar. Applications need to provide their own header bar by placing a single {@link HeaderBar}
> 
> I would like to see this expanded just a little bit, to give an example of what is (system menu, buttons) and is not rendered (rounded corners, app title), similarly to the the table in the JEP.
> 
> I would prefer a table or an `<ul>`, and I specifically want to include the window title.  Window title is a property, and I think it deserves a mention (will it be shown in the tray? in the "running applications" os widget?)
> 
> I don't know whether the best place to include that is here or in the `HeaderBar`.

As for window manager features like rounded corners, I am very certain that this should not be specified. It's out of our control. I've added a paragraph to `HeaderBar` that explains the system menu.

As for the application title, do you think that the existing specification is not sufficient?


 * An extended stage has no title text. Applications that require title text need to provide their own
 * implementation by placing a {@code Label} or a similar control in the custom header bar.
 * Note that the value of {@link Stage#titleProperty()} may still be used by the platform, one example
 * may be the title of miniaturized preview windows.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1832027188