RFR: 8342993: Remove uses of AccessController and AccessControlContext from JavaFX [v2]

[Kevin Rushforth]

On Thu, 14 Nov 2024 23:33:50 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   additional comments
>
> modules/javafx.web/src/main/java/com/sun/webkit/dom/JSObject.java line 45:
> 
>> 43:     // We do this, rather than removing the parameter, in order to keep the
>> 44:     // native WebKit code the same across different release families.
>> 45:     private static final Object dummyAcc = new Object();
> 
> very minor: all uppercase name

done (in many cases I don't think this convention is needed, but it seems good here)

> modules/javafx.web/src/main/java/com/sun/webkit/dom/JSObject.java line 120:
> 
>> 118:     public void setSlot(int index, Object value) throws JSException {
>> 119:         Invoker.getInvoker().checkEventThread();
>> 120:         setSlotImpl(peer, peer_type, index, value,dummyAcc);
> 
> missing space after `,`

fixed

> modules/javafx.web/src/main/java/com/sun/webkit/dom/JSObject.java line 129:
> 
>> 127:     public Object call(String methodName, Object... args) throws JSException {
>> 128:         Invoker.getInvoker().checkEventThread();
>> 129:         return callImpl(peer, peer_type, methodName, args,dummyAcc);
> 
> missing space after `,`

fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1638#discussion_r1844986477
PR Review Comment: https://git.openjdk.org/jfx/pull/1638#discussion_r1844983781
PR Review Comment: https://git.openjdk.org/jfx/pull/1638#discussion_r1844983815