RFR: 8343196: Add build property to identify experimental builds of JavaFX [v2]

Nir Lisker nlisker at openjdk.org
Sun Nov 17 15:33:50 UTC 2024


On Fri, 15 Nov 2024 05:48:15 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Introduce a new build property `jfx.experimental.release.suffix` to be used for the early access builds of an under development feature in JavaFX.
>> This property would be set to a value ONLY in a branch specific to an experiment in [jfx-sandbox](https://github.com/openjdk/jfx-sandbox) repo.
>> For example:
>> For the metal branch in jfx-sandbox repo, it would be set to `-metal`.  The javafx.version for the early access build generated from that branch would be `24-metal`.
>> 
>> And it would always be empty for master branch in both main jfx repo and in jfx-sandbox repo.
>> This change has no effect on a regular developer build from master branch.
>
> Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into exp-suffix
>  - 8343196: Add build property to identify experimental builds of JavaFX

Variants are also something [Gradle](https://docs.gradle.org/current/userguide/variant_model.html#sec:abm-configuration-attributes) uses to select one of several components, so I suggest to avoid this overload. JavaFX should use Gradle variants for selection of operating systems.

I would have went with `jfx.experimental.name` :) because the sandbox has experimental features, as opposed to other features that are directly integrated into the main stream.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1637#issuecomment-2481317205


More information about the openjfx-dev mailing list