RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus [v3]

[Andy Goryachev]

On Mon, 7 Oct 2024 15:30:11 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java line 80:
>> 
>>> 78:  * ({@link #isFocused()} returns {@code true}) and won't respond to unconsumed
>>> 79:  * key events that bubble up from a focused child control. The key presses it
>>> 80:  * acts on are platform specific, but by default should include keys for panning
>> 
>> which keys are platform specific?  I could not find any - the behavior registers no platform-specific bindings.
>
> Perhaps it should read "may be platform specific" -- I just don't want to pin FX down on a specific implementation, as FX is aligning with the platforms it runs on, which it doesn't control.  So if one of the platforms at some point starts using different keys, then I'd expect FX to align with that.

right.  it just feels to me like the sentence "The key presses..." is out of place as it does not specify something that SP has to do.  remove?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1582#discussion_r1790484060