RFR: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus [v3]

John Hendrikx jhendrikx at openjdk.org
Sun Oct 20 22:08:21 UTC 2024


On Mon, 7 Oct 2024 15:52:51 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Perhaps it should read "may be platform specific" -- I just don't want to pin FX down on a specific implementation, as FX is aligning with the platforms it runs on, which it doesn't control.  So if one of the platforms at some point starts using different keys, then I'd expect FX to align with that.
>
> right.  it just feels to me like the sentence "The key presses..." is out of place as it does not specify something that SP has to do.  remove?

I've removed the entire sentence, and also the "by default" part.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1582#discussion_r1807952721


More information about the openjfx-dev mailing list