RFR: 8301121: RichTextArea Control (Incubator) [v29]

[Andy Goryachev]

On Tue, 29 Oct 2024 00:39:23 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 41 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - break iterator
>>  - consume conditionally
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ask to save on closing window
>>  - line numbers, highlight paragraph menus
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ... and 31 more: https://git.openjdk.org/jfx/compare/dc5df6c1...faabd11e
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/BasicTextModel.java line 159:
> 
>> 157:     @Override
>> 158:     public final boolean isWritable() {
>> 159:         return content.isUserEditable();
> 
> Just curious why it is editable in some places but writable in other? Again, description says user-editable name says writable.

changed to writable.

> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/CodeTextModel.java line 95:
> 
>> 93:                 protected void invalidated() {
>> 94:                     TextPos end = getDocumentEnd();
>> 95:                     SyntaxDecorator d = get();
> 
> What does the get() method return? Why is it a decorator? I'm confused...

it is in the context of `SimpleObjectProperty<SyntaxDecorator>()`

this is a common pattern in FX controls' properties

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1821449631
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1821451619