RFR: 8338468: [TestBug] Convert controls tests to JUnit 5 [v2]
Kevin Rushforth
kcr at openjdk.org
Wed Sep 18 11:12:29 UTC 2024
On Wed, 18 Sep 2024 03:50:17 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>>
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls
>> - part 12, 9274 - 185 = 9089
>> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls
>> - part 11, 9242 tests, 185 ignored
>> - part 10
>> - part 9 cell
>> - part 8
>> - part 7
>> - part 6
>> - ... and 6 more: https://git.openjdk.org/jfx/compare/f9b93d88...b5270280
>
> modules/javafx.controls/src/test/java/test/javafx/scene/chart/NumberAxisTest.java line 261:
>
>> 259: @Test
>> 260: public void testCloseValues() {
>> 261: assertTimeout(Duration.ofMillis(1000), () -> {
>
> Could use the [Timeout annotation](https://junit.org/junit5/docs/5.5.1/api/org/junit/jupiter/api/Timeout.html) as : `@Timeout(1)` or `@Timeout(1000 ms)`
Yes, please. I made a similar comment on Draft PR #1569
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1561#discussion_r1764861784
More information about the openjfx-dev
mailing list