RFR: 8338468: [TestBug] Convert controls tests to JUnit 5 [v2]

[Marius Hanl]

On Wed, 18 Sep 2024 11:09:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/NumberAxisTest.java line 261:
>> 
>>> 259:     @Test
>>> 260:     public void testCloseValues() {
>>> 261:         assertTimeout(Duration.ofMillis(1000), () -> {
>> 
>> Could use the [Timeout annotation](https://junit.org/junit5/docs/5.5.1/api/org/junit/jupiter/api/Timeout.html) as :  `@Timeout(1)` or `@Timeout(1000 ms)`
>
> Yes, please. I made a similar comment on Draft PR #1569

Agree, would be good to be consistent, especially now, where we anyway convert everything to JUnit 5 and have the chance to be consistent.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1561#discussion_r1765050711