RFR: 8339510: [TestBug] Convert system tests to JUnit 5

[Kevin Rushforth]

On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Converting system tests to junit5.
> 
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
> 
> ### Notes:
> 
> I see shutdown timeout on linux, this will be addressed by [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
> 
> QPathTest > executionError FAILED
>     org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec
>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
>         at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
>         at app//test.util.Util.runAndWait(Util.java:156)
>         at app//test.util.Util.runAndWait(Util.java:127)
>         at app//test.util.Util.shutdown(Util.java:365)
>         at app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146)
> 
> 
> This test might fail intermittently (?) on linux only:
> 
> SetSceneScalingTest > testShowAndSetScene() FAILED
>     org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
>         at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129)
>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89)
>         at app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193)

You may have already seen this in your testing. When I run with `-PUNSTABLE_TEST=true` I get many failures -- more than I would expect. Here are two examples:


InputDevicePropertyTest > testTouch(TestTouchDevice) > [1] SingleTouchDevice1 FAILED
    java.lang.IllegalStateException: Toolkit not initialized


repeated for each of the parameters and each parameterized test method. So either that test has a preexisting problem, or there is an initialization problem related to the parametrized test change.


RotateTest > testRotateLeftBigSteps(TestTouchDevice) > [1] EGalaxMultiTouchDevice1 FAILED
    java.lang.NullPointerException: Cannot invoke "test.robot.com.sun.glass.ui.monocle.input.devices.TestTouchDevice.getPressedPoints()" because "this.device" is null
        at test.robot.com.sun.glass.ui.monocle.RotateTest.releaseAll(RotateTest.java:75)


repeated for all parameters. This one looks closely related to the parameterized test change.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1569#issuecomment-2359624794