RFR: 8339510: [TestBug] Convert system tests to JUnit 5 [v2]

Andy Goryachev angorya at openjdk.org
Thu Sep 19 21:41:40 UTC 2024


On Wed, 18 Sep 2024 23:17:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   unused imports
>
> tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java line 249:
> 
>> 247:     // Timeout for potential hang on XWayland, see JDK-8335468.
>> 248:     // the same timeout will apply to the rest of the tests
>> 249:     // @Test(timeout = 15000)
> 
> I would remove this commented out line, since it is a JUnit 4 holdover. Also, would it be better to apply the `@Timeout` annotation to just this method? Either is fine with me.

good point

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1767632791


More information about the openjfx-dev mailing list