RFR: 8339510: [TestBug] Convert system tests to JUnit 5 [v6]

[Andy Goryachev]

On Mon, 23 Sep 2024 18:38:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Converting system tests to junit5.
>> 
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>> 
>> ### Notes:
>> 
>> I see shutdown timeout on linux, this will be addressed by [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
>> 
>> QPathTest > executionError FAILED
>>     org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec
>>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
>>         at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
>>         at app//test.util.Util.runAndWait(Util.java:156)
>>         at app//test.util.Util.runAndWait(Util.java:127)
>>         at app//test.util.Util.shutdown(Util.java:365)
>>         at app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146)
>> 
>> 
>> This test might fail intermittently (?) on linux only:
>> 
>> SetSceneScalingTest > testShowAndSetScene() FAILED
>>     org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
>>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
>>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
>>         at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   30 more

The latest commit fixes the number of tests issue.  Note: we should not look at the number of tests reported by gradle at the end of the test run, instead we should look at the HTML report.

master: tests=2728, failures=49, ignored=554 (tests - ignored = 2174)
this PR: tests=2281, failures=96, ignored=107 (test - ignored = 2174)

The actual number of failed tests varies from run to run, and also, being "unstable", differs between master and PR.  For example:


FuzzyTapTest: fails with timeout (TO) vs. passing in master
SingleTouchTest: passing vs. failing with TO in master
TouchButtonTest pass vs failures with TO in master


I also noticed a bug in USKeyboardTest, see https://bugs.openjdk.org/browse/JDK-8340693

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1569#issuecomment-2369211321