RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

Jayathirth D V jdv at openjdk.org
Tue Apr 1 14:39:41 UTC 2025


On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Allows MenuBar to be created in a background thread by delaying MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into 8350976.menubarskin.thread.safety
>  - spelling
>  - use system menu
>  - cleanup
>  - possible fix
>  - test

Previously i had commit until march 26 so again i synced the code to latest master branch build it and then took the changes from this PR(`git fetch https://git.openjdk.org/jfx.git pull/1727/head:pull/1727` & `git checkout pull/1727`) and ran the test and still passes on my macOS 14.7.4 macbook pro laptop.

In the test results also i can see menuBar test as passed.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1727#issuecomment-2769598489


More information about the openjfx-dev mailing list