RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

Jay Bhaskar jbhaskar at openjdk.org
Sat Apr 5 05:27:41 UTC 2025


On Fri, 4 Apr 2025 17:09:20 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove whitespace
>>  - change according to review
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/DateTimeStringConverterTest.java line 104:
> 
>> 102:     private DateFormat validFormatter;
>> 103: 
>> 104:     public DateTimeStringConverterTest(DateTimeStringConverter converter, Locale locale, int dateStyle, int timeStyle, Date validDate, String pattern, DateFormat dateFormat) {
> 
> Is there a reason you did not follow the conversion pattern using setup() method?
> I think the test is mangled now.  Could you please double check?

used paametrized setup

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2029705941


More information about the openjfx-dev mailing list