RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v5]

Jay Bhaskar jbhaskar at openjdk.org
Sat Apr 5 05:27:41 UTC 2025


On Fri, 4 Apr 2025 17:08:25 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   re-order imports
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/DateTimeStringConverterTest.java line 216:
> 
>> 214:             DateFormat dateFormat = DateTimeStringConverterShim.getDateFormatVar(converter);
>> 215:             assertNotNull(dateFormat);
>> 216:         }
> 
> please double-check: the code LL213-L126 looks misplaced here.  it used to be a part of the constructor, and in this case should probably precede the assertions.

re-written test according to others

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2029705858


More information about the openjfx-dev mailing list