RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

Nir Lisker nlisker at openjdk.org
Tue Aug 5 08:57:26 UTC 2025


On Fri, 25 Jul 2025 19:51:32 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into impl-metal
>>  - add comment for ES2SwapChain.getFboID
>>  - remove MTLLog
>>  - andy review comments 1
>>  - changes for running apps in eclipse
>>  - review-update: jni method refactoring
>>  - add @Override
>>  - minor cleanup changes in glass
>>  - Use appropriate layer for setting opacity
>>  - Glass changes after Metal PR inputs
>>  - ... and 2 more: https://git.openjdk.org/jfx/compare/86b80ad2...1a9a0a41
>
> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLTexture.java line 79:
> 
>> 77: 
>> 78:     // We don't handle mipmap in shared texture yet.
>> 79:     private MTLTexture(MTLTexture sharedTex, WrapMode newMode) {
> 
> Raw type

Still needs to be parametrized to `MTLTexture<T>`.

> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLTexture.java line 87:
> 
>> 85:     @Override
>> 86:     protected Texture createSharedTexture(WrapMode newMode) {
>> 87:         return new MTLTexture(this, newMode);
> 
> Raw type

Same, needs to be `MTLTexture<>`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2252737345
PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2252738596


More information about the openjfx-dev mailing list