RFR: 8373038: Interpolator factories should follow method naming convention [v2]

[Kevin Rushforth]

On Thu, 4 Dec 2025 00:10:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - doc changes
>>  - Merge branch 'master' into fixes/interpolator-names
>>  - Interpolator factories should follow method naming convention
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/PaginationSkin.java line 97:
> 
>> 95:     private static final double SWIPE_THRESHOLD = 0.30;
>> 96:     private static final double TOUCH_THRESHOLD = 15;
>> 97:     private static final Interpolator interpolator = Interpolator.ofSpline(0.4829, 0.5709, 0.6803, 0.9928);
> 
> Off-topic: shouldn't this interpolator be specified by the stylesheet (i.e. to be able to modify the transition if needed)?
> 
> More of a question for @kevinrushforth

You mean should it be styleable in pagination? Probably, but I haven't heard anyone request it. It could be an RFE for "some day".

> maybe something like "This poorly named method is deprecated in favor of ..." or words to that extent?

We wouldn't do this in the description, but possibly in the `@deprecated` tag text (not sure).

> or keep the original description?

That's what we typically do, although I can see the value in what @mstr2 proposed. I'll take a look at the built docs and see how it looks.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1996#discussion_r2590640178
PR Review Comment: https://git.openjdk.org/jfx/pull/1996#discussion_r2590668378