RFR: 8373038: Interpolator factories should follow method naming convention [v2]
Michael Strauß
mstrauss at openjdk.org
Thu Dec 4 21:57:37 UTC 2025
On Thu, 4 Dec 2025 21:40:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java line 192:
>>
>>> 190:
>>> 191: /**
>>> 192: * Use {@link #ofSpline(double, double, double, double)}.
>>
>> maybe something like "This poorly named method is deprecated in favor of ..." or words to that extent?
>>
>> or keep the original description?
>
>> maybe something like "This poorly named method is deprecated in favor of ..." or words to that extent?
>
> We wouldn't do this in the description, but possibly in the `@deprecated` tag text (not sure).
>
>> or keep the original description?
>
> That's what we typically do, although I can see the value in what @mstr2 proposed. I'll take a look at the built docs and see how it looks.
I've commited the suggested change without noticing your reply here. The description is now similar to:
* This is a legacy method named inconsistently with method naming conventions,
* use {@link #ofSpline(double, double, double, double)} instead.
I can revert the change, or keep the existing description.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1996#discussion_r2590705707
More information about the openjfx-dev
mailing list