RFR: 8250802: Refactor StringConverter and its subclasses [v5]

Nir Lisker nlisker at openjdk.org
Tue Dec 23 09:04:23 UTC 2025


On Mon, 22 Dec 2025 23:44:44 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify thread safety
>
> modules/javafx.base/src/main/java/javafx/util/converter/BooleanStringConverter.java line 28:
> 
>> 26: package javafx.util.converter;
>> 27: 
>> 28: /// A `StringConverter` implementation for `Boolean` (and `boolean`) values. Formatting is done by [Boolean#toString()]
> 
> The `Boolean` reference is currently a hyperlink. Did you remove it intentionally?

All the parametric types are linked in the superclass definition when the HTML docs are rendered: `extends StringConverter<Boolean>`. Look at https://openjfx.io/javadoc/25/javafx.base/javafx/util/converter/BooleanStringConverter.html to see if the link in the description is still needed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2642462987


More information about the openjfx-dev mailing list