RFR: 8250802: Refactor StringConverter and its subclasses [v5]
Nir Lisker
nlisker at openjdk.org
Tue Dec 23 09:40:14 UTC 2025
On Mon, 22 Dec 2025 23:52:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Clarify thread safety
>
> modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java line 37:
>
>> 35: ///
>> 36: /// Note that using `Date` is not recommended in JDK versions where [java.time.LocalDateTime] is available, in which
>> 37: /// case [LocalDateTimeStringConverter] should be used.
>
> Should we consider deprecating this class (not for removal)?
We should definitely consider it. One question is: if the JDK didn't deprecate `Date`, should we deprecate its converter? By deprecating the converter, we're basically telling the user to update their internal model to `java.time` classes (which is a good thing) because there's no other way to fix this deprecation as I see it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2642585128
More information about the openjfx-dev
mailing list