RFR: 8349756: Memory leak in PaginationSkin when setting page count / index [v2]

Andy Goryachev angorya at openjdk.org
Tue Feb 11 22:22:59 UTC 2025


> ## Root Cause
> 
> Each time a `PaginationSkin.IndicatorButton` gets created it adds two listeners (to the control's `styleClass` property and to the skin's tooltipVisible property) via `ListenerHelper`.  This was not detected by the `SkinMemoryLeakTest` because all listeners got removed correctly upon skin change.
> 
> ## Solution
> 
> Add a single listener to the control's `styleClass` property at the skin level, and insert the call to the skin's `tooltipVisible` property both of which iterate over indicator button to do their thing.

Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:

  back to constructor

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1705/files
  - new: https://git.openjdk.org/jfx/pull/1705/files/fc222966..66c0b2ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1705&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1705&range=00-01

  Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jfx/pull/1705.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1705/head:pull/1705

PR: https://git.openjdk.org/jfx/pull/1705


More information about the openjfx-dev mailing list