RFR: 8349756: Memory leak in PaginationSkin when setting page count / index [v2]
Andy Goryachev
angorya at openjdk.org
Tue Feb 11 22:22:59 UTC 2025
On Tue, 11 Feb 2025 21:39:19 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> back to constructor
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/PaginationSkin.java line 201:
>
>> 199:
>> 200: navigation = new NavigationControl();
>> 201: navigation.initializePageIndicators();
>
> Minor: would it make sense to move this back to the`NavigationControl` constructor (at the end)?
good point, thanks! fixed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1705#discussion_r1951688218
More information about the openjfx-dev
mailing list