RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin [v2]

[Ambarish Rapte]

On Wed, 26 Feb 2025 23:39:27 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - enforced fx application thread
>> - added a headful test `TestThreadingRestrictions`
>> 
>> ## Note to the Reviewers
>> 
>> To avoid merge conflicts, the preferred order of integrations:
>> 
>> #1697 
>> #1713 
>> #1717
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge remote-tracking branch 'origin/master' into 8350048.enforce
>  - fixed node init test
>  - all tests
>  - initial test

modules/javafx.controls/src/main/java/javafx/scene/control/ChoiceBox.java line 491:

> 489:             setShowing(true);
> 490:         }
> 491:     }

Would it be a good idea to move the check `Toolkit.getToolkit().checkFxUserThread();` to a new method `show()` in Parent class `Control`? And may be similarly to Parent classes of other classes.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1717#discussion_r1973034032