RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin [v2]

[Kevin Rushforth]

On Thu, 27 Feb 2025 07:43:59 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8350048.enforce
>>  - fixed node init test
>>  - all tests
>>  - initial test
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ChoiceBox.java line 491:
> 
>> 489:             setShowing(true);
>> 490:         }
>> 491:     }
> 
> Would it be a good idea to move the check `Toolkit.getToolkit().checkFxUserThread();` to a new method `show()` in Parent class `Control`? And may be similarly to Parent classes of other classes.

No, we don't want to add a new public `show` method to `Control` since it is only a very few controls that have the concept of showing a popup.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1717#discussion_r1973616028